Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Django 4.2 #208

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Upgrade to Django 4.2 #208

merged 4 commits into from
Jan 8, 2025

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Jan 7, 2025 •
edited
Loading

Description of the changes

  • Moved from Django 3.2 to 4.2
  • Django 4.2 allows us to use psycopg 3 instead of 2, so I have updated that as well.
  • Also moved to newer python 3.12 (newest supported by django 4.2) which then allowed a newer version of pytest.
  • Updated to newest django-auth-ldap. I manually tested that ldap still works.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (340030e) to head (ada1f34).

Additional details and impacted files 
@@            Coverage Diff             @@
##             next     #208      +/-   ##
==========================================
- Coverage   77.86%   77.86%   -0.01%     
==========================================
  Files          54       54              
  Lines        4730     4729       -1     
==========================================
- Hits         3683     3682       -1     
  Misses       1047     1047

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosswhitfield rosswhitfield marked this pull request as ready for review January 8, 2025 04:02
@rosswhitfield rosswhitfield requested a review from backmari January 8, 2025 04:16
backmari
backmari approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rosswhitfield rosswhitfield merged commit c91f6dd into next Jan 8, 2025
4 checks passed
@rosswhitfield rosswhitfield deleted the django4.2 branch January 8, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backmari backmari backmari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosswhitfield @codecov-commenter @backmari